Re: Patch: BasicLookAndFeel initComponentDefaults

[Roman Kennke <roman at kennke dot org>]

Hi Lillian,

Am Mittwoch, den 21.12.2005, 15:23 -0500 schrieb Lillian Angel:
> 2005-12-20  Lillian Angel  <langel@redhat.com>
> 
>         * gnu/testlet/javax/swing/plaf/basic/BasicLookAndFeel/
> 	initComponentDefaults.java:
>         Added checks for TextArea.focusInputMap, 
> 	TextField.focusInputMap, TextPane.focusInputMap, and 
> 	PasswordField.focusInputMap.
> 


+    harness.check(UIManager.get("PasswordField.focusInputMap")
instanceof InputMapUIResource);

The test could be a little more detailed. I know that lots of tests in
this test class are like you did. You have implemented ~27 keybindings
for each text component, it would be helpful to check all of them.
Sorry, it's alot of work (ok, lots of copy+pasting ;-) ), but it's
really worth the effort. So, what should be done is, check for the type
and size of the Object[] value for this key, and do a check for each
keystroke and binding in the array (for KeyStrokes I would do a
harness.check(keystroke.toString(), "ctrl ENTER") kind of check (to
avoid confusion, because both (String and KeyStroke objects) are legal
for the KeyStroke part, for the binding a simple harness.check(binding,
"notify-accept") kind of check will do. Would you mind adding such
checks?

/Roman

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil