This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
libffi and .note.GNU-stack (Was: ctypes patches)
- From: Anthony Green <green at redhat dot com>
- To: Thomas Heller <theller at ctypes dot org>, Jakub Jelinek <jakub at redhat dot com>
- Cc: libffi-discuss at sourceware dot org
- Date: Tue, 26 Feb 2008 10:26:13 -0800
- Subject: libffi and .note.GNU-stack (Was: ctypes patches)
- References: <47C44300.1060209@ctypes.org>
Thomas Heller wrote:
Here are patches from the Python/ctypes libffi fork, for the src directory.
It would be great if they were applied, in full or partially, to the libffi CVS repository.
- (src/x86/sysv.S) Patch #1560695: Add .note.GNU-stack to ctypes' sysv.S so that
ctypes isn't considered as requiring executable stacks.
If I recall correctly, Jakub applied similar patches to the Fedora/RHEL
gcc/libffi. Jakub - was this patch submitted to the FSF?
Thomas - your patch says:
+#ifdef __ELF__
+.section .note.GNU-stack,"",%progbits
+#endif
...but other patches floating out there say:
+#if defined(__linux__) && defined(__ELF__)
+.section .note.GNU-stack,"",%progbits
+#endif
... I assume because .note.GNU-stack is Linux specific. Do you agree?
Thanks,
AG