Re: upcoming glibc 2.9 - i486 problem

[Mike Frysinger <vapier at gentoo dot org>]

On Monday 17 November 2008 12:44:52 Arkadiusz Miskiewicz wrote:
> On Sunday 16 of November 2008, Arkadiusz Miskiewicz wrote:
> > On Saturday 15 of November 2008, Arkadiusz Miskiewicz wrote:
> > > I have such build failure on i486 linux:
> >
> > Update: i686, athlon, x86_64, ppc built fine. Only i486 failed.
>
> --- libc-HEAD/sysdeps/i386/dl-tlsdesc.S.org	2008-11-17 18:17:04.004203199
> +0100 +++ libc-HEAD/sysdeps/i386/dl-tlsdesc.S	2008-11-17 18:18:28.029877701
> +0100 @@ -128,8 +128,7 @@
>  .Lslow:
>  	cfi_adjust_cfa_offset (28)
>  	movl	%ebx, 16(%esp)
> -	call	__i686.get_pc_thunk.bx
> -	addl	$_GLOBAL_OFFSET_TABLE_, %ebx
> +	LOAD_PIC_REG(bx)
>  	call	___tls_get_addr@PLT
>  	movl	16(%esp), %ebx
>  	jmp	.Lret

FYI drepper appears to have fixed this in the meantime in head:
commit e41177ea18a77a7f62328293b4fd49ae17482e77
Author: Ulrich Drepper <drepper@redhat.com>
Date:   Sat Dec 6 00:15:17 2008 +0000

    (_dl_tlsdesc_dynamic): Use LOAD_PIC_REG instead of doing things manually.

diff --git a/sysdeps/i386/dl-tlsdesc.S b/sysdeps/i386/dl-tlsdesc.S
index db5005d..4d17e59 100644
--- a/sysdeps/i386/dl-tlsdesc.S
+++ b/sysdeps/i386/dl-tlsdesc.S
@@ -128,8 +128,7 @@ _dl_tlsdesc_dynamic:
 .Lslow:
    cfi_adjust_cfa_offset (28)
    movl    %ebx, 16(%esp)
-   call    __i686.get_pc_thunk.bx
-   addl    $_GLOBAL_OFFSET_TABLE_, %ebx
+   LOAD_PIC_REG (bx)
    call    ___tls_get_addr@PLT
    movl    16(%esp), %ebx
    jmp .Lret
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.