This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix nis_getnames

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Tue, 5 Dec 2006 20:52:09 +0100
Subject: [PATCH] Fix nis_getnames
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

NIS_PATH is already in UNSECURE_ENVVARS, so ld.so unsetenv's
it during start of suid/sgid programs, so all this __secure_getenv
does is prohibit suid/sgid programs to setenv NIS_PATH to some value
and expect nis_lookup or nis_list with EXPAND_NAME flag set to use it.

2006-12-05  Jakub Jelinek  <jakub@redhat.com>

	* nis/nis_subr.c (nis_getnames): Revert last change.

--- libc/nis/nis_subr.c.jj	2006-10-19 17:26:39.000000000 +0200
+++ libc/nis/nis_subr.c	2006-12-05 20:47:11.000000000 +0100
@@ -178,7 +178,7 @@ nis_getnames (const_nis_name name)
     }
 
   /* Get the search path, where we have to search "name" */
-  path = __secure_getenv ("NIS_PATH");
+  path = getenv ("NIS_PATH");
   if (path == NULL)
     path = strdupa ("$");
   else

	Jakub

Follow-Ups:
- Re: [PATCH] Fix nis_getnames
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]