This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix tst-mallocfork

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Mon, 28 Nov 2005 13:45:15 +0100
Subject: [PATCH] Fix tst-mallocfork
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

As detected by valgrind, sa_flags was uninitialized when calling
sigaction.  Fixed thusly.

2005-11-28  Jakub Jelinek  <jakub@redhat.com>

	* malloc/tst-mallocfork.c (do_test): Make sure sa_flags is
	initialized.  Reported by John Reiser <jreiser@BitWagon.com>.

--- libc/malloc/tst-mallocfork.c.jj	2005-09-27 07:42:06.000000000 +0200
+++ libc/malloc/tst-mallocfork.c	2005-11-28 13:28:48.000000000 +0100
@@ -22,9 +22,8 @@ do_test (void)
 {
   pid_t parent = getpid ();
 
-  struct sigaction action;
+  struct sigaction action = { .sa_handler = sig_handler };
   sigemptyset (&action.sa_mask);
-  action.sa_handler = sig_handler;
 
   malloc (sizeof (int));
 

	Jakub

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]