This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Use __attribute__ instead of __attribute in installed headers

Hi!

<sys/cdefs.h> defines just __attribute__(x) to nothing for crappy
compilers, but not __attribute(x).  So I think we should use
the former form.

2005-11-24  Jakub Jelinek  <jakub@redhat.com>

	[BZ #1920]
	* sysdeps/pthread/pthread.h (__pthread_unwind_next): Use
	__attribute__ instead of __attribute.
	* sysdeps/unix/sysv/linux/i386/bits/pthreadtypes.h
	(__cleanup_fct_attribute): Likewise.

--- libc/nptl/sysdeps/unix/sysv/linux/i386/bits/pthreadtypes.h.jj	2004-09-30 00:50:03.000000000 +0200
+++ libc/nptl/sysdeps/unix/sysv/linux/i386/bits/pthreadtypes.h	2005-11-24 18:23:25.000000000 +0100
@@ -1,4 +1,4 @@
-/* Copyright (C) 2002, 2003, 2004 Free Software Foundation, Inc.
+/* Copyright (C) 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -155,6 +155,6 @@ typedef union
 
 
 /* Extra attributes for the cleanup functions.  */
-#define __cleanup_fct_attribute __attribute ((regparm (1)))
+#define __cleanup_fct_attribute __attribute__ ((regparm (1)))
 
 #endif	/* bits/pthreadtypes.h */
--- libc/nptl/sysdeps/pthread/pthread.h.jj	2005-09-12 09:29:08.000000000 +0200
+++ libc/nptl/sysdeps/pthread/pthread.h	2005-11-24 18:19:22.000000000 +0100
@@ -657,9 +657,9 @@ extern void __pthread_unregister_cancel_
 
 /* Internal interface to initiate cleanup.  */
 extern void __pthread_unwind_next (__pthread_unwind_buf_t *__buf)
-     __cleanup_fct_attribute __attribute ((__noreturn__))
+     __cleanup_fct_attribute __attribute__ ((__noreturn__))
 # ifndef SHARED
-     __attribute ((__weak__))
+     __attribute__ ((__weak__))
 # endif
      ;
 #endif

	Jakub
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]