This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fixes for make clean (take 2)

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>, Andreas Jaeger <aj at suse dot de>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Sat, 8 Jan 2005 17:38:55 +0100
Subject: [PATCH] Fixes for make clean (take 2)
References: <m3sm5ibwe5.fsf@gromit.moeb> <20050107124425.GB17169@sunsite.mff.cuni.cz> <m3brc12veq.fsf@gromit.moeb>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Fri, Jan 07, 2005 at 02:58:21PM +0100, Andreas Jaeger wrote:
> > This change is bad:
> > make[2]: Entering directory
> > `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/elf' Makefile:726: warning: overriding commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
> > ../Rules:118: warning: ignoring old commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
> > mkdir /usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf
> >
> > I think putting tst-pie1.out and tst-pie1 into generated instead would cure
> > this.
> 
> I'll revert my patch now,

This seems to work for me:

2005-01-08  Jakub Jelinek  <jakub@redhat.com>

	* elf/Makefile (generated): Add tst-pie1{,.out,.o}.

--- libc/elf/Makefile.jj	2005-01-08 16:50:21.000000000 +0100
+++ libc/elf/Makefile	2005-01-08 17:24:04.000000000 +0100
@@ -734,6 +734,8 @@ $(objpfx)tst-pie1: $(objpfx)tst-pie1.o $
 	  -L$(subst :, -L,$(rpath-link)) -Wl,-rpath-link=$(rpath-link) \
 	  -o $@ $(objpfx)tst-pie1.o $(objpfx)tst-piemod1.so \
 	  $(common-objpfx)libc_nonshared.a
+
+generated += tst-pie1 tst-pie1.out tst-pie1.o
 endif
 
 check-textrel-CFLAGS = -O -Wall -D_XOPEN_SOURCE=600 -D_BSD_SOURCE


	Jakub

Follow-Ups:
- Re: [PATCH] Fixes for make clean (take 2)
  - From: Andreas Jaeger

References:
- Fixes for make clean
  - From: Andreas Jaeger
- Re: Fixes for make clean
  - From: Jakub Jelinek
- Re: Fixes for make clean
  - From: Andreas Jaeger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]