This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Warning patrol


Hi!

res_send.c: In function `__libc_res_nsend':
res_send.c:580: warning: unused variable `tmpbuf'
In file included from ../nptl/sysdeps/unix/sysv/linux/powerpc/lowlevellock.h:24,
                 from ../nptl/descr.h:33,
                 from ../nptl/sysdeps/powerpc/tls.h:61,
                 from ../include/tls.h:6,
                 from ../include/errno.h:22,
                 from ../sysdeps/unix/sysv/linux/powerpc/powerpc64/sysdep.h:29,
                 from ../sysdeps/powerpc/fpu/bits/mathinline.h:128,
                 from ../math/math.h:382,
                 from ../include/math.h:3,
                 from ../sysdeps/ieee754/dbl-64/s_atan.c:45:
../sysdeps/unix/sysv/linux/sys/param.h:64:1: warning: "MIN" redefined
In file included from ../sysdeps/ieee754/dbl-64/s_atan.c:41:
../sysdeps/ieee754/dbl-64/mpa.h:67:1: warning: this is the location of the previous definition
tst-popen.c: In function `do_test':
tst-popen.c:49: warning: implicit declaration of function `strcmp'

2004-08-11  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/ieee754/dbl-64/mpa.c: Include sys/param.h.
	* sysdeps/ieee754/dbl-64/mpa.h (MAX, MIN): Remove.

	* stdio-common/tst-popen.c: Include string.h.

	* resolv/res_send.c (__libc_res_nsend): Only define tmpbuf if DEBUG.

--- libc/sysdeps/ieee754/dbl-64/mpa.c.jj	2002-08-27 00:40:37.000000000 +0200
+++ libc/sysdeps/ieee754/dbl-64/mpa.c	2004-08-11 13:42:14.714036294 +0200
@@ -47,6 +47,7 @@
 #include "endian.h"
 #include "mpa.h"
 #include "mpa2.h"
+#include <sys/param.h>	/* For MIN() */
 /* mcr() compares the sizes of the mantissas of two multiple precision  */
 /* numbers. Mantissas are compared regardless of the signs of the       */
 /* numbers, even if x->d[0] or y->d[0] are zero. Exponents are also     */
--- libc/sysdeps/ieee754/dbl-64/mpa.h.jj	2002-08-27 00:40:37.000000000 +0200
+++ libc/sysdeps/ieee754/dbl-64/mpa.h	2004-08-11 13:42:39.737652146 +0200
@@ -63,8 +63,6 @@ typedef union { int i[2]; double d; } nu
 #define  EY  y->e
 #define  EZ  z->e
 
-#define MAX(x,y) ((x) < (y) ?  (y) : (x))
-#define MIN(x,y) ((x) < (y) ?  (x) : (y))
 #define ABS(x)   ((x) <  0  ? -(x) : (x))
 
 int __acr(const mp_no *, const mp_no *, int);
--- libc/stdio-common/tst-popen.c.jj	2004-07-23 20:38:30.000000000 +0200
+++ libc/stdio-common/tst-popen.c	2004-08-11 13:29:09.593518344 +0200
@@ -18,6 +18,7 @@
    02111-1307 USA.  */
 
 #include <stdio.h>
+#include <string.h>
 #include <wchar.h>
 
 static int
--- libc/resolv/res_send.c.jj	2004-08-11 13:24:55.000000000 +0200
+++ libc/resolv/res_send.c	2004-08-11 13:27:59.379804446 +0200
@@ -577,7 +577,9 @@ __libc_res_nsend(res_state statp, const 
 		}
 
 #ifdef _LIBC
+# ifdef DEBUG
 		char tmpbuf[40];
+# endif
 		Dprint(statp->options & RES_DEBUG,
 		       (stdout, ";; Querying server (# %d) address = %s\n",
 			ns + 1, inet_ntop(AF_INET6, &nsap->sin6_addr,

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]