This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix pthread_cond_broadcast on s390/s390x

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>, Martin Schwidefsky <schwidefsky at de dot ibm dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Tue, 22 Jun 2004 11:15:49 +0200
Subject: [PATCH] Fix pthread_cond_broadcast on s390/s390x
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

This pasto caused in the better case most of FUTEX_CMP_REQUEUE calls return
-EAGAIN, but if unlucky it might even succeed when it was supposed to fail.
Tested on both s390 and s390x.

2004-06-22  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/s390/lowlevellock.h (lll_futex_requeue):
	Set __r7 to val, not mutex.

--- libc/nptl/sysdeps/unix/sysv/linux/s390/lowlevellock.h.jj	2004-06-11 14:45:53.000000000 +0200
+++ libc/nptl/sysdeps/unix/sysv/linux/s390/lowlevellock.h	2004-06-22 13:26:54.911154237 +0200
@@ -91,7 +91,7 @@
     register unsigned long int __r4 asm ("4") = (long int) (nr_wake);	      \
     register unsigned long int __r5 asm ("5") = (long int) (nr_move);	      \
     register unsigned long int __r6 asm ("6") = (unsigned long int) (mutex);  \
-    register unsigned long int __r7 asm ("7") = (int) (mutex);		      \
+    register unsigned long int __r7 asm ("7") = (int) (val);		      \
     register unsigned long __result asm ("2");				      \
 									      \
     __asm __volatile ("svc %b1"						      \

	Jakub

Follow-Ups:
- Re: [PATCH] Fix pthread_cond_broadcast on s390/s390x
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]