This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix file descriptor and memory leak in pmap_set

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Tue, 30 Dec 2003 12:30:20 +0100
Subject: [PATCH] Fix file descriptor and memory leak in pmap_set
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

CLNT_DESTROY is needed both in the success and failure cases.

2003-12-30  Jakub Jelinek  <jakub@redhat.com>

	* sunrpc/pmap_clnt.c (pmap_set): Do CLNT_DESTROY even if CLNT_CALL
	failed.  Reported by Steve Grubb.

--- libc/sunrpc/pmap_clnt.c.jj	2002-08-06 03:23:20.000000000 +0200
+++ libc/sunrpc/pmap_clnt.c	2003-12-30 14:03:52.000000000 +0100
@@ -135,7 +135,7 @@ pmap_set (u_long program, u_long version
 		 tottimeout) != RPC_SUCCESS)
     {
       clnt_perror (client, _("Cannot register service"));
-      return FALSE;
+      rslt = FALSE;
     }
   CLNT_DESTROY (client);
   /* (void)close(socket); CLNT_DESTROY closes it */

	Jakub

Follow-Ups:
- Re: [PATCH] Fix file descriptor and memory leak in pmap_set
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]