This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Avoid warnings on s390*

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>, Roland McGrath <roland at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Thu, 30 Jan 2003 12:37:15 +0100
Subject: [PATCH] Avoid warnings on s390*
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

The following patch kills 2 warnings on s390*:
../sysdeps/generic/libc-tls.c: In function `__libc_setup_tls':
../sysdeps/generic/libc-tls.c:199: warning: initialization makes pointer from integer without a cast
../sysdeps/s390/libc-tls.c: In function `__tls_get_offset':
../sysdeps/s390/libc-tls.c:33: warning: implicit declaration of function `abort'

2003-01-30  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/s390/libc-tls.c: Include stdlib.h.
linuxthreads/
	* sysdeps/s390/tls.h (TLS_INIT_TP): Return NULL, not 0.

--- libc/linuxthreads/sysdeps/s390/tls.h.jj	2003-01-30 05:01:47.000000000 -0500
+++ libc/linuxthreads/sysdeps/s390/tls.h	2003-01-30 05:51:48.000000000 -0500
@@ -110,7 +110,7 @@ typedef struct
     head->self = _descr;						      \
 									      \
     __builtin_set_thread_pointer (_descr);				      \
-    0;									      \
+    NULL;								      \
   })
 
 /* Return the address of the dtv for the current thread.  */
--- libc/sysdeps/s390/libc-tls.c.jj	2003-01-28 05:34:50.000000000 -0500
+++ libc/sysdeps/s390/libc-tls.c	2003-01-30 05:53:42.000000000 -0500
@@ -1,4 +1,4 @@
-/* Thread-local storage handling in the ELF dynamic linker.  IA-64 version.
+/* Thread-local storage handling in the ELF dynamic linker.  S390 version.
    Copyright (C) 2003 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
@@ -17,6 +17,7 @@
    Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
    02111-1307 USA.  */
 
+#include <stdlib.h>
 #include <sysdeps/generic/libc-tls.c>
 
 #if USE_TLS
@@ -34,4 +35,3 @@ __tls_get_offset (size_t m, size_t offse
 }
 
 #endif
-

	Jakub

Follow-Ups:
- Re: [PATCH] Avoid warnings on s390*
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]