This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: i386/strchr.S broken?

Ignore the patch - I understand the algorithm now.  But now I'd like
to add a comment to it.

Ok to commit to mainline?
Andreas

2002-08-10  Andreas Jaeger  <aj@suse.de>

	* sysdeps/i386/strchr.S: Add comment.
============================================================
Index: sysdeps/i386/strchr.S
--- sysdeps/i386/strchr.S	6 Jul 2001 04:55:52 -0000	1.11
+++ sysdeps/i386/strchr.S	10 Aug 2002 17:01:19 -0000
@@ -1,6 +1,6 @@
 /* strchr (str, ch) -- Return pointer to first occurrence of CH in STR.
    For Intel 80x86, x>=3.
-   Copyright (C) 1994, 1995, 1996, 1997, 1999, 2000 Free Software Foundation, Inc.
+   Copyright (C) 1994, 1995, 1996, 1997, 1999, 2000, 2002 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Ulrich Drepper <drepper@gnu.ai.mit.edu>
    Some optimisations by Alan Modra <Alan@SPRI.Levels.UniSA.Edu.Au>
@@ -254,7 +254,9 @@ L(71):	addl $4, %eax
 
 	/* We now scan for the byte in which the character was matched.
 	   But we have to take care of the case that a NUL char is
-	   found before this in the dword.  */
+	   found before this in the dword.  Note that we XORed the %ecx
+	   with the byte we're looking for, therefore the tests below look
+	   reversed.  */
 
 L(7):	testb %cl, %cl		/* is first byte C? */
 	jz L(6)			/* yes => return pointer */

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]