This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: _IO_wfile_underflow_mmap error/eof case

From: Ulrich Drepper <drepper at redhat dot com>
To: Roland McGrath <roland at frob dot com>
Cc: GNU libc hackers <libc-hacker at sources dot redhat dot com>
Date: Tue, 30 Jul 2002 14:43:41 -0700
Subject: Re: _IO_wfile_underflow_mmap error/eof case
References: <20020730212258.520C01BA1B@perdition.linnaean.org>

Roland McGrath wrote:

It seems to me that:

      fp->_flags |= _IO_EOF_SEEN;

in _IO_wfile_underflow_mmap is wrong.  In that case,
_IO_file_underflow_mmap has already set either the EOF or ERROR flag bit.
If there was an error rather than EOF, the EOF bit should not be set too.
Am I missing something or should I remove this line?

Might just be a copy&paste thing. Is it noticeable from user code? Or the other way around: do you have code which stresses this code?

--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------

Follow-Ups:
- Re: _IO_wfile_underflow_mmap error/eof case
  - From: Roland McGrath

References:
- _IO_wfile_underflow_mmap error/eof case
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]