This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix struct stat* (was Re: attribute(packed) in struct stat is wrong)

From: Ulrich Drepper <drepper at redhat dot com>
To: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: 07 Feb 2002 20:53:40 -0800
Subject: Re: [PATCH] Fix struct stat* (was Re: attribute(packed) in struct stat is wrong)
References: <hoeljxh3m6.fsf@gee.suse.de><20020207152827.D558@sunsite.ms.mff.cuni.cz>
Reply-to: drepper at redhat dot com (Ulrich Drepper)

Jakub Jelinek <jakub@redhat.com> writes:

> 2002-02-07  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* sysdeps/unix/sysv/linux/bits/stat.h (struct stat): Remove packed
> 	attribute, change __pad{1,2} type to unsigned int.
> 	(struct stat64): Remove packed attribute.

Well, this is better.  I don't know why I haven't seen any problem
yesterday but I've seen them today.  And your patch fixes the test
suite problems.

Which is not handled is using stat64 with -malign-double.  And I doubt
it can be handled.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

References:
- attribute(packed) in struct stat is wrong
  - From: Andreas Jaeger
- [PATCH] Fix struct stat* (was Re: attribute(packed) in struct stat is wrong)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]