This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[PATCH] Kill i386 assembly warning in glibc


Hi!

Using orb with eax is probably not what has been intended, either orb.*al or
orl.*eax should fix it.

2000-06-30  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/i386/bits/string.h (strcmp): Use 8bit register in 8bit
	instruction.

--- libc/sysdeps/i386/bits/string.h.jj	Mon Oct  4 09:26:50 1999
+++ libc/sysdeps/i386/bits/string.h	Fri Jun 30 10:34:56 2000
@@ -1,5 +1,5 @@
 /* Optimized, inlined string functions.  i386 version.
-   Copyright (C) 1997, 1998, 1999 Free Software Foundation, Inc.
+   Copyright (C) 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -470,7 +470,7 @@ strcmp (__const char *__s1, __const char
      "jmp	3f\n"
      "2:\n\t"
      "sbbl	%%eax,%%eax\n\t"
-     "orb	$1,%%eax\n"
+     "orb	$1,%%al\n"
      "3:"
      : "=a" (__res), "=&S" (__d0), "=&D" (__d1)
      : "1" (__s1), "2" (__s2)

	Jakub

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]