Re: [PATCH] +groups ignored

[Thorsten Kukuk <kukuk at suse dot de>]

On Fri, Jun 27, Jakub Jelinek wrote:

> On Fri, Jun 27, 2003 at 01:20:52PM +0200, Thorsten Kukuk wrote:
> > @@ -300,13 +299,15 @@
> >        if (result->gr_name[0] == '+' && result->gr_name[1] != '\0'
> >  	  && result->gr_name[1] != '@')
> >  	{
> > +	  char buf[strlen (result->gr_name)];
> >  	  enum nss_status status;
> >  
> >  	  /* Store the group in the blacklist for the "+" at the end of
> >  	     /etc/group */
> > -	  blacklist_store_name (&result->gr_name[1], ent);
> > +	  strcpy (buf, &result->gr_name[1]);
> 
> If you already compute strlen (result->gr_name), wouldn't it be better to
> use it then (memcpy is faster than strcpy)?

Ok, here is a new patch for compat-grp.c and compat-pwd.c.

  Thorsten

-- 
Thorsten Kukuk       http://www.suse.de/~kukuk/        kukuk@suse.de
SuSE Linux AG        Deutschherrnstr. 15-19        D-90429 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B

Attachment: glibc-2.3.dif
Description: Text document

Attachment: pgp00000.pgp
Description: PGP signature