This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: dbxread.c warning fix

From: Daniel Jacobowitz <drow at false dot org>
To: Alan Modra <amodra at bigpond dot net dot au>
Cc: gdb-patches at sourceware dot org
Date: Thu, 15 May 2008 08:07:29 -0400
Subject: Re: dbxread.c warning fix
References: <20080515005352.GC11328@bubble.grove.modra.org>

On Thu, May 15, 2008 at 10:23:52AM +0930, Alan Modra wrote:
> Some recent versions of gcc warn that passing nlist to set_namestring
> results in uninitialised memory access.  The warning is correct since
> n_other isn't initialised and the whole struct is passed by copying to
> set_namestring.  This belts and braces patch corrects
> INTERNALIZE_SYMBOL to init n_other, and changes set_namestring to take
> a pointer arg.  OK to apply?
> 
> 	* dbxread.c: Formatting.
> 	(INTERNALIZE_SYMBOL): Init n_other.
> 	(set_namestring): Take pointer to nlist arg rather than struct
> 	copy.  Update all callers.

OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery

References:
- dbxread.c warning fix
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]