This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Recognize 'x' in response to 'p' packet


Daniel Jacobowitz <drow@false.org> writes:

> On Thu, Dec 23, 2004 at 11:25:51AM -0500, Jim Blandy wrote:
> > Jim Blandy <jimb@redhat.com> writes:
> > 
> > > Daniel Jacobowitz <drow@false.org> writes:
> > > > My real question, though, is what you needed this for - and whether
> > > > marking the register unavailable fixes it.
> > > 
> > > The Red Hat Debug Agent generates replies to 'p' packets that contain
> > > 'x's.  GDB generally seems to work, but 'info thread' fares poorly.
> > > Simply parsing the response at all should fix the problem; I'll make
> > > sure that marking the register as unavailable doesn't cause any new
> > > problems.
> > > 
> > > Thanks for the review!
> > 
> > Okay, here's the revised patch, against the properly re-indented
> > sources.  Tested against RDA.
> > 
> > 2004-12-17  Jim Blandy  <jimb@redhat.com>
> > 
> > 	* remote.c (fetch_register_using_p): Recognize a register value
> > 	starting with 'x' as indicating an unfetchable register.
> 
> OK, thanks!  I will be getting around to adding 'p' to gdbserver soon,
> so I'll need this too.

Committed --- thanks for the review.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]