This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] dwarf2cfi.c improvements

From: Andrew Cagney <ac131313 at cygnus dot com>
To: Michal Ludvig <mludvig at suse dot cz>
Cc: GDB Patches <gdb-patches at sources dot redhat dot com>,Elena Zannoni <ezannoni at redhat dot com>
Date: Mon, 03 Jun 2002 09:43:26 -0400
Subject: Re: [RFA] dwarf2cfi.c improvements
References: <3CF79DA0.9040404@suse.cz>

  	internal_error (__FILE__, __LINE__,
! 			"%s: unknown pointer encoding: 0x%x",
! 			__func__, encoding);
        }

Michael,

Just FYI, __func__ can't be used. It isn't considered part of the ISO C that GDB builds to.

!     error ("%s: CFA is not defined as CFA_REG_OFFSET", __func__);

Hmm, I don't think user error messages need to include function names.

Can I suggest pulling the error() and internal_error() message changes out, cleaning them up, and then committing them separatly. Better messages (eg printing the reason for a bad switch) are always a good idea.

That also has the benefit of trimming your patch back.

enjoy,
Andrew

Follow-Ups:
- Re: [RFA] dwarf2cfi.c improvements
  - From: Michal Ludvig

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]