This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] monitor.c fix for rom68k target boards
- To: Jeff Holcomb <jeffh at redhat dot com>
- Subject: Re: [RFA] monitor.c fix for rom68k target boards
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Fri, 30 Mar 2001 15:58:17 -0500
- Cc: gdb-patches at sources dot redhat dot com
- References: <Pine.SOL.3.91.1010329214948.571m-100000@cse.cygnus.com>
Jeff Holcomb wrote:
>
> This patch allows gdb to work with rom68k target boards once again (it's
> been broken for a year and a half apparently).
>
> I don't think the routine needs to care about checking for termination of
> the string. In the case of this monitor, the SR is returned as
> "2700-tfSm.111...xnzvc" for example. Before Jason's change to this
> routine, it used strtoul which ended the matching at the first non
> digit. Jason changed it to work with values larger than 'long' so it's
> now a hand-coded loop to gather the digits.
So the old code would just return with ``p'' pointing to one char beyond
the hex digit?
Andrew