Re: Patch: grep ^func

["Eli Zaretskii" <eliz at is dot elta dot co dot il>]

> Date: Thu, 25 Jan 2001 14:22:04 -0800 (PST)
> From: Don Howard <dhoward@cygnus.com>
>  
> Here is a simple patch that cleans up function declarations/definitions 
> so that grep ^func will turn up only the function definition.  

Can you tell why is this change necessary?  Don't we have tools like
etags to identify function definitions?

In general, I think gratuitous changes in whitespace should be
avoided, since they get in the way when you need to figure out what
_real_ changes in the code happened since the last time you looked.
(Yes, I know about the -bBw switches to Diff, but they sometimes hide
real changes.)

> Index: go32-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/go32-nat.c,v
> retrieving revision 1.6
> diff -p -u -w -r1.6 go32-nat.c
> --- go32-nat.c	2000/08/06 07:19:38	1.6
> +++ go32-nat.c	2001/01/25 20:55:29
> @@ -1,6 +1,6 @@
>  /* Native debugging support for Intel x86 running DJGPP.
> -   Copyright 1997, 1999 Free Software Foundation, Inc.
> -   Written by Robert Hoehne.
> +   Copyright 1997, 1999, 2001 Free Software Foundation, Inc.  Written
> +   by Robert Hoehne.

This change includes reformatting of white space in a comment.  I
think in this case the reformatting is completely unnecessary.  If
Robert Hoehne, who wrote the bulk of go32-nat.c, wanted his credits to
be on a separate line, I think we should grant him that privilege.  So
please undo this reformatting.