Re: Patch for TearDownProcess

[Elena Zannoni <elena dot zannoni at oracle dot com>]

Andrew Cagney wrote:
> Unfortunately this isn't theoretical.  On a slower f5 machine; this 
> happens consistently; invalidating test results.

Can you post more information about the things you are seeing? Whatever 
is in the bugzilla does not have enough details to diagnose the problem. 
At this point you are the only one knowing what is going on in
your tests, it would be nice if you could share the information with the 
rest of the team. If nothing else, just
out of respect for the work that Kris put into finding the cause of the 
hangs in the first place, explaining that
to you last night on irc and writing a patch.
If the patch exposed other problems, a civil procedure is to discuss 
things with the patch author
instead of steamrolling your changes in, obliterating other's people work.

> Given the choices between a potential test-suite hang, and tear-down 
> leaving waitpid events around, the decision was made in favor of the 
> latter.  That decision hasn't changed.  Having the test run hang, is a 
> lesser evil then the test-suite continuing but producing bogus results..

Who made that decision? Can you explain why hangs in the testsuite 
(which have been there for a long time)
are reasonable to have? I would think that an intelligent person and a 
hard core proponent of extreme programming and other formal development 
methods like yourself would want to put a big emphasis on
the QA of this project, so I am sure missing something here.

> I restored the old behavior; and then added a timeout.  It currently 
> logs a message, I suspect it should abandon the test run, since the 
> problem state hasn't gone away.

I don't think that's what you did. You reimplemented Kris change.