Re: frysk-core/frysk/proc Breakpoint.java IsaIA32. ...

[Phil Muldoon <pmuldoon at redhat dot com>]

mark@sourceware.org wrote:
> CVSROOT:	/cvs/frysk
> Module name:	frysk-core
> Changes by:	mark@sourceware.org	2007-01-15 13:48:47
>
> Modified files:
> 	frysk/proc     : Breakpoint.java IsaIA32.java IsaX8664.java 
> 	                 LinuxIa32On64.java LinuxPtraceTaskState.java 
> 	                 TestTaskObserverInstruction.java 
> 	                 TestTaskObserverInstructionAndCode.java 
>
> Log message:
> 	Fixes bug #3676
> 	* Breakpoint.java (stepDone): Only set if still installed.
> 	(isInstalled): new method.
> 	(toString): Prettify.
> 	* IsaIA32.java (isTaskStepped): Reset flag.
> 	* IsaX8664.java (isTaskStepped): Likewise.
>   

Mark,

As we talked about on irc, and in addition to looking at this code in 
preparation  for hardware watchpoints, can I make a small recommendation 
here?

isTaskStepped(task) is a query, and should imo not be altering any debug 
registers after the fact.

Can I propose a split into:

isTaskStepped(task) and setTaskStepped(task)

Does that make better sense?

Regards

Phil