This is the mail archive of the
frysk@sources.redhat.com
mailing list for the frysk project.
Re: frysk-core/frysk util/TestFStack.java util/Sta ...
- From: Mark Wielaard <mark at klomp dot org>
- To: frysk at sourceware dot org
- Cc: npremji at sourceware dot org
- Date: Tue, 19 Dec 2006 11:54:30 +0100
- Subject: Re: frysk-core/frysk util/TestFStack.java util/Sta ...
- References: <20061218182438.13405.qmail@sourceware.org>
Hi,
On Mon, 2006-12-18 at 18:24 +0000, npremji@sourceware.org wrote:
> * ProcBlockAction.java (ProcBlockAction): Added call to addFailed if proc has bad ownership.
> [...]
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ProcBlockAction.java.diff?cvsroot=frysk&r1=1.6&r2=1.7
> @@ -141,7 +140,7 @@
>
> if (! isOwned)
> {
> - // ("Process " + proc + " is not owned by user/group.");
> + addFailed(proc, new Throwable("Process " + proc + " is not owned by user/group."));
> }
>
> taskList = proc.getTasks();
Should there be a return statement after the addFailed()? So we don't
try to do any other work, like getting the task list and trying to do a
requestAdd() (which will of course also fail)?
Cheers,
Mark