Re: How to handle Clone/Fork/Exec when traceSyscall is true

[Sami Wagiaalla <swagiaal at redhat dot com>]

> Hi, Sami, sorry for delayed reply!
>
> I read your code in these three days, and it looks great!
>
> Task State Machine cost me a lot of time to understand it, so I have
> some questions about your code modifications to Task State Machine,
> and free to correct me if I make any wrong assumptions.
>
> 1) From class SyscallRunning, I find that, in syscallRunning state, 
> when ExecedEvent is got, the state will transit to runningInSyscall
> state (Am I right?).  I doubt that syscallRunning do not get
> ExecedEvent, and no need to handle ExecedEvent.  If State Machine goes
> to syscallRunning state, that means it will trace syscalls, so frysk
> will get SyscallEvent earlier than ExecedEvent, and transit to
> runningInSyscall, and syscallRunning state do not need to handle
> ExecedEvent.  I run testExecSyscall, and could not find that
> syscallRunning handle ExecedEvent.  Any comments on this?
>   
Thank makes sense. I removed it all the tests pass... its gone :)
> 2) Task State Machine is complicated (about 25 states), and we could
> hardly find problems in Task State Machine, at least I could not,
> so unit test cases are needed to help us to verify the functionality 
> of Task State Machine, but sadly, some of the unit test cases are
> skipped or could not work well, why don't we enable them?  I enabled
> and modified some test cases, and they indeed expose some problems.  I
> would like to code a patch to improve these test case in
> frysk-core/frysk/proc/, and good test case could tell us how State
> Machine work and how to make State Machine work better.
>   
Great!.. we could use all the help we can get. Enable, write tests, send 
patches
all you want.
> 3) I make a State Chart of Task State Machine per your code, and it
> could tell us how states transit from one to another triggered by
> different events or observers.  This picture is 300+ KB, and I 
> am not sure it is suitable to send the attachment to maillist in 
> such size or not.  Could I send this picture to this maillist?
>   
Nice...  what did you use to makethe chart ?.. If you have some web space
you can upload it. You can also send it to me directly.

Sami