Re: [PATCH] Add logging of move-on-reboot scheduling

[Igor Pechtchanski <pechtcha at cs dot nyu dot edu>]

On 14 Mar 2003, Robert Collins wrote:

> On Fri, 2003-03-14 at 10:07, Igor Pechtchanski wrote:
> > On 14 Mar 2003, Robert Collins wrote:
>
> > > Please Extract Method on the duplicate code here.
> > > Cheers,
> > > Rob
> >
> > Umm, shouldn't we do this as two separate steps?  There's duplicate code
> > galore all over that function...  Or do you want it all in one patch?
>
> I was only worried about the code that is being touched by the patch. I
> think it's sufficiently small that a single patch will be ok.
>
> Just describe in the patch log the two steps.
> Cheers,
> Rob

Actually, the rest of the function wasn't that bad, and I might as well do
it all at once, at least for the logging.
	Igor
==============================================================================
ChangeLog:
2003-03-13  Igor Pechtchanski <pechtcha at cs dot nyu dot edu>

	* install.cc (install_one_source): Add logging for
	successful replace-on-reboot scheduling.  Factor out
	duplicate code.  Set rebootneeded on Win9x.
	(log_ror_failure) New static function.
	(log_ror_success) New static function.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor at watson dot ibm dot com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
  -- /usr/games/fortune

Attachment: setup-install-log-inuse.patch
Description: Text document