This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[RFA:] ld-scripts/default-script: globalize tested symbol
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: binutils at sourceware dot org
- Date: Tue, 28 Jul 2009 22:34:46 -0400 (EDT)
- Subject: [RFA:] ld-scripts/default-script: globalize tested symbol
At the moment, mmix-knuth-mmixware fails these tests, because there's
no notion of local symbols (they're gone) in the mmo format. The test
doesn't look like the globalness of the value is important; rather the
value. So, how about making the symbol global? Alternatives are to
skip the test for mmix-knuth-mmixware or add a "-m elf64-mmix" to the
linker options to force conformant output like SPU does.
Tested crosses to mmix-knuth-mmixware and mips-linux (mips has its own
non-obvious ".global") and native i686-pc-linux-gnu.
BTW, several gas ports override common pseudos like .global but with
the default value. Looks like a misunderstanding; the md_pseudo_table
need only list the overrides.
Ok to commit? Or is an alternative preferred?
* ld-scripts/default-script.s (text): Globalize.
* ld-scripts/default-script1.d, ld-scripts/default-script2.d,
ld-scripts/default-script3.d, ld-scripts/default-script4.d: Adjust
accordingly.
Index: ld-scripts/default-script.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/default-script.s,v
retrieving revision 1.1
diff -p -u -r1.1 default-script.s
--- ld-scripts/default-script.s 19 Jan 2007 14:51:27 -0000 1.1
+++ ld-scripts/default-script.s 29 Jul 2009 02:18:17 -0000
@@ -1,3 +1,4 @@
.text
+ .global text
text:
.long 0
Index: ld-scripts/default-script1.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/default-script1.d,v
retrieving revision 1.2
diff -p -u -r1.2 default-script1.d
--- ld-scripts/default-script1.d 13 Feb 2007 22:14:59 -0000 1.2
+++ ld-scripts/default-script1.d 29 Jul 2009 02:18:17 -0000
@@ -5,5 +5,5 @@
#...
0*8000000 . _START
#...
-0*8000000 t text
+0*8000000 T text
#pass
Index: ld-scripts/default-script2.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/default-script2.d,v
retrieving revision 1.2
diff -p -u -r1.2 default-script2.d
--- ld-scripts/default-script2.d 13 Feb 2007 22:14:59 -0000 1.2
+++ ld-scripts/default-script2.d 29 Jul 2009 02:18:17 -0000
@@ -5,5 +5,5 @@
#...
0*8000000 . _START
#...
-0*9000000 t text
+0*9000000 T text
#pass
Index: ld-scripts/default-script3.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/default-script3.d,v
retrieving revision 1.2
diff -p -u -r1.2 default-script3.d
--- ld-scripts/default-script3.d 13 Feb 2007 22:14:59 -0000 1.2
+++ ld-scripts/default-script3.d 29 Jul 2009 02:18:17 -0000
@@ -5,5 +5,5 @@
#...
0*8000000 . _START
#...
-0*8000000 t text
+0*8000000 T text
#pass
Index: ld-scripts/default-script4.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/default-script4.d,v
retrieving revision 1.2
diff -p -u -r1.2 default-script4.d
--- ld-scripts/default-script4.d 13 Feb 2007 22:14:59 -0000 1.2
+++ ld-scripts/default-script4.d 29 Jul 2009 02:18:17 -0000
@@ -5,5 +5,5 @@
#...
0*8000000 . _START
#...
-0*8000000 t text
+0*8000000 T text
#pass
brgds, H-P