This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] fix ld testsuite failures with gcc 3.3.x on i386 (was Re: Binutils 2.18 available)
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Jan Beulich <jbeulich at novell dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 26 Sep 2007 22:33:28 +0930
- Subject: Re: [PATCH] fix ld testsuite failures with gcc 3.3.x on i386 (was Re: Binutils 2.18 available)
- References: <20070828220801.GA14075@caradoc.them.org> <46D5483F.76E4.0078.0@novell.com> <20070829115536.GA18550@caradoc.them.org> <46D5ADC4.76E4.0078.0@novell.com> <20070829163544.GA32606@caradoc.them.org> <46F39F7A.76E4.0078.0@novell.com> <46FA51AA.76E4.0078.0@novell.com>
On Wed, Sep 26, 2007 at 11:33:46AM +0100, Jan Beulich wrote:
> * elf32-i386.c (elf_i386_check_relocs): Revert NULL pointer
> check for R_386_GNU_VTINHERIT.
> * elf-m10300.c (mn10300_elf_check_relocs): Check for NULL
> pointer for R_xxx_GNU_VTENTRY.
> * elf32-arm.c (elf32_arm_check_relocs): Likewise.
> * elf32-bfin.c (bfin_check_relocs): Likewise.
> (bfinfdpic_check_relocs): Likewise.
> * elf32-cris.c (cris_elf_check_relocs): Likewise.
> * elf32-d10v.c (elf32_d10v_check_relocs): Likewise.
> * elf32-dlx.c (elf32_dlx_check_relocs): Likewise.
> * elf32-fr30.c (fr30_elf_check_relocs): Likewise.
> * elf32-frv.c (elf32_frv_check_relocs): Likewise.
> * elf32-iq2000.c (iq2000_elf_check_relocs): Likewise.
> * elf32-m32r.c (m32r_elf_check_relocs): Likewise.
> * elf32-m68hc1x.c (elf32_m68hc11_check_relocs): Likewise.
> * elf32-m68k.c (elf_m68k_check_relocs): Likewise.
> * elf32-mcore.c (mcore_elf_check_relocs): Likewise.
> * elf32-openrisc.c (openrisc_elf_check_relocs): Likewise.
> * elf32-ppc.c (ppc_elf_check_relocs): Likewise.
> * elf32-s390.c (elf_s390_check_relocs): Likewise.
> * elf32-score.c (_bfd_score_elf_check_relocs): Likewise.
> * elf32-sh.c (sh_elf_check_relocs): Likewise.
> * elf32-v850.c (v850_elf_check_relocs): Likewise.
> * elf32-vax.c (elf_vax_check_relocs): Likewise.
> * elf32-xstormy16.c (xstormy16_elf_check_relocs): Likewise.
> * elf32-xtensa.c (elf_xtensa_check_relocs): Likewise.
> * elf64-mmix.c (mmix_elf_check_relocs): Likewise.
> * elf64-ppc.c (ppc64_elf_check_relocs): Likewise.
> * elf64-s390.c (elf_s390_check_relocs): Likewise.
> * elf64-sh64.c (sh_elf64_check_relocs): Likewise.
> * elf64-x86-64.c (elf64_x86_64_check_relocs): Likewise.
> * elfxx-mips.c (_bfd_mips_elf_check_relocs): Likewise.
> * elfxx-sparc.c (_bfd_sparc_elf_check_relocs): Likewise.
> * elf32-hppa.c (elf32_hppa_check_relocs): Likewise. Also handle
> NULL pointer case for R_PARISC_GNU_VTINHERIT.
OK, except
> --- 2007-09-25/bfd/elf32-hppa.c 2007-08-22 11:01:42.000000000 +0200
> +++ 2007-09-25/bfd/elf32-hppa.c 2007-09-26 00:00:00.000000000 +0200
> @@ -1271,14 +1271,18 @@ elf32_hppa_check_relocs (bfd *abfd,
> /* This relocation describes the C++ object vtable hierarchy.
> Reconstruct it for later use during GC. */
> case R_PARISC_GNU_VTINHERIT:
> - if (!bfd_elf_gc_record_vtinherit (abfd, sec, &hh->eh, rela->r_offset))
> + if (!bfd_elf_gc_record_vtinherit (abfd, sec,
> + hh != NULL ? &hh->eh : NULL,
> + rela->r_offset))
there is no need to change this.
&hh->eh == (struct elf_link_hash_entry *) hh
--
Alan Modra
Australia Development Lab, IBM