RE: Binutils Port - Infineon xc16x family.

["Shrirang Khishti" <shrirangk at KPITCummins dot com>]

 Hi Nick
 
 >>   * Please submit the ChangeLog entries for individual ChangeLog 
 >>files, rather than just one gigantic ChangeLog entry.
 
 I am attaching a tar file with this mail. It includes individual 
 ChangeLog Entries.
 
 >> * The patch to the top level config.sub file will have to be 
 >>submitted  separately to the config project.
 
 I am sending following top level config patch to config project
 (<config-patches@gnu.org>) 
 --------------------------------------------------------------
 
 --- config.sub.orig	2006-02-22 18:56:45.692539648 +0530
 +++ config.sub	2006-02-21 15:51:23.000000000 +0530
 @@ -281,7 +281,7 @@
  	| tahoe | thumb | tic4x | tic80 | tron \
  	| v850 | v850e \
  	| we32k \
 -	| x86 | xscale | xscalee[bl] | xstormy16 | xtensa \
 +	| x86 | xscale | xscalee[bl] | xstormy16 | xtensa | xc16x\
  	| z8k)
  		basic_machine=$basic_machine-unknown
  		;;
 @@ -367,7 +367,7 @@
  	| v850-* | v850e-* | vax-* \
  	| we32k-* \
  	| x86-* | x86_64-* | xps100-* | xscale-* | xscalee[bl]-* \
 -	| xstormy16-* | xtensa-* \
 +	| xstormy16-* | xtensa-* | xc16x-* \
  	| ymp-* \
  	| z8k-*)
  		;;
 --------------------------------------------------------------
 
 >>* You missed a patch to the ld/Makefile.am file.  As
 well I added
 >>entries to the ld/NEWS and gas/NEWS files mentioning the
 fact that the
 >>new target has been added.
 
 Yes I missed it. Anyways thanks for applying it.
 
 >>   * Will you be acting as maintainers for this target ?  If so, 
 >>please add yourselves to the binutils/MAINTAINERS file.
 
 Yes I would like to take up this responsibility. 
 
 >>* You asked that the port be configured with --disable-Werror.  
 >>This I did not do.  Instead I configured it as normal and
 >>fixed all of the warning messages that were being turned into errors.

 >>Really you could have done this yourselves.
 
 >>   * I was very pleased to see that you have contributed some xc16c 
 >>specific GAS and LD tests.  I have applied these as well.  There is 
 >>one problem though: 20 unexpected failures in the new GAS
 tests and 1
 >>in the new LD tests.  I hope that you will fix these soon.
 
 I analyzed the failures and found that GAS failures are because of 
 changes made in xc16x.opc file for removing the warnings.
 
 In functions parse_hash , parse_sof, parse_pof, parse_seg, parse_pag 
 If we change following code (as you have changed)
 Code1:	 "If ( condition  ) 
 		 {
 		 Str ++ ;
  	 	 Return NULL;
 		 }"
 
 To 
 Code2:	 "
 		 If (condition)
 		 Str ++ ;
 		 Return NULL ";
 		
 It removes the warnings which is expected but then it is giving 
 assembler failures.
 
 After I revert the changes u suggested, test-cases are working fine. 
 Any comments from u on this part? 


Regards
Shrirang Khisti 					
KPIT Cummins Infosystems Ltd.

Attachment: binutils-Changelog.tar.gz
Description: binutils-Changelog.tar.gz