This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[Patch] i386pe align .rdata for sse[2]

From: Brian Ford <ford at vss dot fsi dot com>
To: binutils at sources dot redhat dot com
Date: Wed, 22 Sep 2004 17:17:47 -0500
Subject: [Patch] i386pe align .rdata for sse[2]

As those of us from Cygwin recently found out, gcc >= 3.4 puts constants
in .rdata now.  If those constants are used by sse[2] instructions (ie.
via -mfpmath=sse), then they may be misaligned when sections are
concatonated since the default .rdata section alignment is currently
2**2=4 (sse[2] instructions need 16 byte aligned data).

This patch is exactly parallel to:

2002-06-14  Sergey Grigoriev  <serge@leopold.Physik.Uni-Augsburg.DE>

        * pei-i386.c (COFF_SECTION_ALIGNMENT_ENTRIES): Enable 16 byte
        alignment for .bss, .data and .text sections so that sse and sse2
        code will work.
        * pe-i386.c (COFF_SECTION_ALIGNMENT_ENTRIES): Likewise.

So...

2004-09-22  Brian Ford  <ford@vss.fsi.com>

	* pei-i386.c (COFF_SECTION_ALIGNMENT_ENTRIES): Enable 16 byte
	alignment for .rdata sections so sse[2] code work with gcc >= 3.4
	constatnts.
	* pe-i386.c (COFF_SECTION_ALIGNMENT_ENTRIES): Likewise.

Ok to apply?

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
the best safety device in any aircraft is a well-trained pilot...

Attachment: pe_sse_align_rdata.patch
Description: Text document

Follow-Ups:
- Re: [Patch] i386pe align .rdata for sse[2]
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]