This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gcc/gdb/as/ld issue


Hi Andy,

> Thanks for taking the trouble to look at this. Unfortunately, as I
> later point out in this thread, using the length's not good enough
> in our environment as even the length was the same in some instances
> where the name was different and so stabs were being removed
> erroneously causing gdb to go bang.

Ah - I had missed that last post to the thread, sorry.

> My latter patch solves that issue for us and doesn't seem to kill
> performance (for us anyway). There is a missing free in that patch
> which was making it use more memory than necessary though:
>
> @@ -433,6 +464,9 @@
>                  pass to change the type to N_EXCL.  */
>               ne->type = (int) N_EXCL;
>  
> +             /* Free off superfluous symbols.  */
> +             free(symb);
> +
>               /* Mark the skipped symbols.  */
>  
>               nest = 0;

Ok - please apply this update to your original patch and check it in,
along with a suitable ChangeLog entry, of course.

Cheers
        Nick
        


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]