This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: obj_coff vs section_hash
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: DJ Delorie <dj at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 22 Jan 2002 11:29:14 +1030
- Subject: Re: obj_coff vs section_hash
- References: <200201220020.g0M0Knn21310@greed.delorie.com>
On Mon, Jan 21, 2002 at 07:20:49PM -0500, DJ Delorie wrote:
>
> This was causing multiple .stabstr sections, which makes the cygwin
> linker core. Since we have no way of either checking for these cases
I'm surprised that this didn't cause a problem before now. section->name
isn't copied either.
> in subseg_get or letting the caller say whether the string should be
> copied or not, perhaps we should (instead of this patch) be
> conservative and pass "true" for the copy parameter in
> section_hash_lookup in bfd/section.c?
I think fixing the callers of subseg_get is best, at least until
you're sure that nothing compares string pointers. ;)
--
Alan Modra
IBM OzLabs - Linux Technology Centre