Re: Fix for alignment of .stab section in sh-pe gas

[Nick Clifton <nickc at cygnus dot com>]

Hi Joern,

: > 	* config/tc-sh.h (SUB_SEGMENT_ALIGN): Give the .stab section an
: > 	alignment of 2 and the .stabstr section an alignment of 0.
: 
: So why are you still suppressing the effect of the -small option?

Because I do not know what it does and it was not being supported
before.  If you think it is sensible to add this support to the
definition of SUB_SEGMENT_ALIGN then I will do so.

: > 	* config/tc-sh.c (sh_cons_align): Do not generate alignment
: > 	frags in the .stab section.
: 
: Do you want to suppress the alignment because the data is in the stab
: section, or because it's a .stabn / .stabs pseudo-op?
: If the answer is the latter, then you can do that by using special
: functions to process stabn / stabs, which set sh_no_align_cons before
: calling s_stab.
: The s_uacons function in tc-sh.c aleady uses sh_no_align_cons to
: implement .uaword.

No its the former.  The presence of the alignment frags in the .stab
section upsets the alignment of the section when it is generated later
on.  This is happening because s_stab_generic() in gas/stabs.c is
calling cons() to read the last part of a stab, which in turn is
triggering a call to sh_cons_align().

Cheers
	Nick