Re: false automatically discovered file `foo.c' should not beexplicitly mentioned warnings

[Alexandre Duret-Lutz <duret_g at lrde dot epita dot fr>]

>>> "assar" == assar  <assar@kth.se> writes:

 assar> Having two targets, one of which includes @LIBOBJS@ (or @LTLIBOJS@)
 assar> and one which includes one of the autoconf-ed files automake does
 assar> generate the "automatically discovered" warning.  This makes no sense
 assar> to me.  

Neither to me.

 assar> A testcase for this is included in the patch below.  The
 assar> patch is relative to current cvs automake, makes the
 assar> error only happen if the @LIBOBJS@ is also included.

Thanks a lot!  However, as explained in
http://sources.redhat.com/automake/contribute.html we need
a copyright assignment before we can install patches more that a
few lines long.  Would you be willing to sign such a paper so
we can use your code?  (I'll send you the form in a separate
mail).   

Further comments on your patch below, but that's just
formatting changes to follow the GNU Coding Standards.

[...]

 assar> --- automake.in	23 Aug 2002 13:32:55 -0000	1.1342
 assar> +++ automake.in	24 Aug 2002 03:34:57 -0000
 assar> @@ -2177,6 +2177,20 @@
 assar> {
 assar> my ($one_file, $unxformed) = @_;

This seems a good place for a comment :)
 
 assar> +    my @objs;
 assar> +    my $found_libobjs = 0;
 assar> +
 assar> +    @objs = &variable_value_as_list_recursive ($unxformed, 'all');
 assar> +    foreach my $i (@objs) {
                                  ^new line here
 assar> +      if($i =~ /^\@(LT)?LIBOBJS\@$/) {
                 ^space                      ^new line 
 assar> +	$found_libobjs = 1;
 assar> +	last;
 assar> +      }
 assar> +    }
 assar> +    if (!$found_libobjs) {
                                 ^new line
 assar> +      return;
 assar> +    }


[...]

 assar> --- /dev/null	1 Jan 1970 00:00:00 -0000
 assar> +++ tests/libobj12.test	24 Aug 2002 03:34:58 -0000
 assar> @@ -0,0 +1,30 @@
 assar> +#! /bin/sh
 assar> +
 assar> +# $Id$

Ouch, please no!  RCS-keywords are more anoying than useful.

[...]

-- 
Alexandre Duret-Lutz