This is the mail archive of the automake@gnu.org mailing list for the automake project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

PATCH: avoid exponential memory usage


Attached is a patch that's been around for a long time, in the gstreamer
package.  It fixes a longstanding bug in automake that causes it to use
exponential amounts of memory, as a function of the number of subdirs
listed in a Makefile.  Currently automake uses either 4GB or 8GB of memory
to process our plugins/Makefile.am, unless it's patched.  We have had to
hack our autogen.sh in order to test for this patch and apply it if it's
not there, but this just broke with the release of 1.4-p5.

Please apply this patch, so we can stop having to keep up with the many
versions of automake.  The patch as attached will not apply to 1.4-p5.
The block of code in question starts at line 2438 in -p5.

TIA,
   Omega

      Erik Walthinsen <omega@temple-baptist.com> - System Administrator
        __
       /  \                GStreamer - The only way to stream!
      |    | M E G A        ***** http://gstreamer.net/ *****
      _\  /_
--- 1
+++ 2
@@ -2383,8 +2383,8 @@
 	# to all possible directories, and use it.  If DIST_SUBDIRS is
 	# defined, just use it.
 	local (\$dist_subdir_name);
-	if (&variable_defined ('DIST_SUBDIRS')
-	    || &variable_conditions ('SUBDIRS'))
+	if (&variable_conditions ('SUBDIRS')
+	    || &variable_defined ('DIST_SUBDIRS'))
 	{
 	    \$dist_subdir_name = 'DIST_SUBDIRS';
 	    if (! &variable_defined ('DIST_SUBDIRS'))

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]