This is the mail archive of the automake@gnu.org mailing list for the automake project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Automake 1.4j: Release Candidate [PATCH]


Richard Boulton <richard@tartarus.org> writes:
> Removing the @parent_conds machinery and simply recursing through the
> conditional variables and taking all the possible conditional combinations
> makes sense to me, and works correctly as far as I can tell.  
[snip]
> -	# If this condition cannot be true when the parent conditions
> -	# are true, then skip it.
> -	next
> -	  if ! conditionals_true_when (@parent_conds, $vcond);
[snip]
> -	    next
> -	      if ! conditionals_true_when (@parent_conds, $perm);

Since you kill the only two calls to 'conditionals_true_when', why not
kill 'conditionals_true_when' too :-)

- Hari
-- 
Raja R Harinath ------------------------------ harinath@cs.umn.edu
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]