This is the mail archive of the
automake@gnu.org
mailing list for the automake project.
Re: 15-file-contents-paragraph.patch
- To: Akim Demaille <akim at epita dot fr>
- Subject: Re: 15-file-contents-paragraph.patch
- From: Tom Tromey <tromey at redhat dot com>
- Date: 31 Jan 2001 11:19:37 -0700
- Cc: Automake <automake at gnu dot org>
- List-Id: Discussion list for automake <automake.gnu.org><mailto:automake-request@gnu.org?subject=unsubscribe>
- References: <E14NmSO-0005dM-00@nostromo.lrde.epita.fr>
- Reply-To: tromey at redhat dot com
>>>>> "Akim" == Akim Demaille <akim@epita.fr> writes:
Akim> * automake.in (file_contents): Rewrite: instead of trying to parse
Akim> it line by line, first swallow it completely into $CONTENTS,
Akim> *then*, parse it *paragraph* by paragraph.
I see this went in.
What is the rationale for this patch?
I'm very leery of changing file reading. For &file_contents it isn't
too worrisome, since we have complete control over the inputs. For
the other file reader it is scarier.
Also, the patch that went in has some unconditional prints to STDERR.
This is wrong.
Tom