This is the mail archive of the automake@gnu.org mailing list for the automake project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: 10-check-am.patch


>>>>> "Akim" == Akim Demaille <akim@epita.fr> writes:

Akim> 	* automake.in (handle_phony): Sort.
Akim> 	* automake.in (file_contents_with_transform): Catch `.PHONY:'.
Akim> 	* check.am: New file.

check.am wasn't in the patch.  However, I trust it is just an
extraction from handle_tests.

Please add a ChangeLog entry for handle_tests.  Also, the ChangeLog
entry shouldn't repeat `automake.in':

	* automake.in (handle_phony): Sort.
	(file_contents_with_transform): Catch `.PHONY:'.
	* check.am: New file.

(This is an absurdly nitty nit.)

Finally, could you move the `Solaris 2.7' comment from handle_tests
into check.am and make it into a `##' comment?  In fact, move it to
just above the line it comments.


It is fine to `cvs add' a file so that `cvs diff -N' creates the
correct diff.  This applies generally -- if you don't have cvs write
access there is a script you can get that will do a phony `cvs add' by
manipulating CVS/Entries.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]