This is the mail archive of the
automake@gnu.org
mailing list for the automake project.
Re: 07-prog-error.patch
- To: Akim Demaille <akim at epita dot fr>
- Subject: Re: 07-prog-error.patch
- From: Tom Tromey <tromey at redhat dot com>
- Date: 28 Jan 2001 18:41:17 -0700
- Cc: Automake <automake at gnu dot org>
- List-Id: Discussion list for automake <automake.gnu.org><mailto:automake-request@gnu.org?subject=unsubscribe>
- References: <E14MuTg-0006UA-00@nostromo.lrde.epita.fr>
- Reply-To: tromey at redhat dot com
>>>>> "Akim" == Akim Demaille <akim@epita.fr> writes:
Akim> * automake.in (prog_error): New.
Akim> Spread its use.
This is fine.
Akim> + &prog_error ("version is incorrect: $VERSION")
Akim> + if ($VERSION !~ /([0-9]+)\.([0-9]+)([a-z])?/);
The automake style is to write trailing `if's without parens:
+ &prog_error ("version is incorrect: $VERSION")
+ if $VERSION !~ /([0-9]+)\.([0-9]+)([a-z])?/;
(unless the condition requires a line break, then parens are added so
that tab will work -- sort of like the GNU style for C)
Could you make this change?
Tom