This is the mail archive of the automake@gnu.org mailing list for the automake project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Automake security problem


On Mar  1, 2000, Jim Meyering <meyering@ascend.com> wrote:

> 	Don't use `ln' (which was just a space optimization anyway)

A worthwhile optimization, IMO.  There are some `find' hacks in the
`dist' rules to avoid modifying the permissions in the source tree,
but, unfortunately, they do not apply to the final `chmod -R a+w' at
the end of `dist' or `dist-all', nor to the beginning of `distcheck' or
`distdir'.  We should probably replace:

	-chmod -R a+w $(distdir) > /dev/null 2>&1; rm -rf $(distdir)

with:

        -find $(distdir) -type d -exec chmod a+w {} \; ; rm -rf $(distdir)

And it would fix the whole problem without disabling the
optimization.  Note that distcheck applies several other chmod to
distdir, but only after it is created from scratch, in a
hard-link-free way, by extracting the sources from the dist file.

-- 
Alexandre Oliva     http://www.ic.unicamp.br/~oliva/     Enjoy Guaranį
Cygnus Solutions, a Red Hat company        aoliva@{redhat, cygnus}.com
Free Software Developer and Evangelist    CS PhD student at IC-Unicamp
oliva@{lsd.ic.unicamp.br, gnu.org}   Write to mailing lists, not to me


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]