This is the mail archive of the
automake-prs@sourceware.org
mailing list for the automake project.
Re: automake/501: abbreviating the .Po-related output somewhat
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: adl at sources dot redhat dot com
- Cc: automake-prs at sources dot redhat dot com,
- Date: 29 Aug 2006 11:41:02 -0000
- Subject: Re: automake/501: abbreviating the .Po-related output somewhat
- Reply-to: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
The following reply was made to PR automake/501; it has been noted by GNATS.
From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Paul Eggert <eggert@CS.UCLA.EDU>
Cc: automake-gnats@sources.redhat.com
Subject: Re: automake/501: abbreviating the .Po-related output somewhat
Date: Tue, 29 Aug 2006 13:39:22 +0200
[ sorry for the resend ]
Hello Paul,
* Paul Eggert wrote on Tue, Aug 29, 2006 at 09:31:01AM CEST:
>
> So, for now, how about this fix instead?
> gcc -std=gnu99 -I. -I. -I../lib -I../lib -g -O2 -MTdd.o -MD -MP -MF.deps/dd.Tpo -c -o dd.o dd.c
> mv -f .deps/dd.Tpo .deps/dd.Po
If you remove the spaces after -MT and -MF, you should also change this
in the depcomp script: that way, the configure test also verifies that
the compiler understands this. Rationale: I don't know whether there
are other compilers imitating gcc3 depmode imperfectly. See patchlet
below.
> @@ -115,10 +117,11 @@ if %?LIBTOOL%
[...]
> +?!GENERIC? %LTCOMPILE% -MT%LTOBJ% -MD -MP -MF%DEPBASE%.Tpo %-c% -o %LTOBJ% `test -f '%SOURCE%' || echo '$(srcdir)/'`%SOURCE%
> +?GENERIC??!SUBDIROBJ? %LTCOMPILE% -MT%LTOBJ% -MD -MP -MF%DEPBASE%.Tpo %-c% -o %LTOBJ% %SOURCE%
> +?GENERIC??SUBDIROBJ? depbase=`echo %OBJ% | sed 's|[^/]*$$|$(DEPDIR)/&|;s|\.lo$$||'`; \
FWIW, you remove all spaces before the final backslash-newline except in
the line above.
> +?GENERIC??SUBDIROBJ? %LTCOMPILE% -MT%LTOBJ% -MD -MP -MF%DEPBASE%.Tpo %-c% -o %LTOBJ% %SOURCE% &&\
> + mv -f %DEPBASE%.Tpo %DEPBASE%.Plo
Other than these nits, I can't find any issues with this. In fact, I
like that it fixes a minor unrelated nit I've had with these rules for
a while: cut'n'paste into an interactive shell will not cause a failing
compilation to try to exit the shell any more. :-)
Cheers,
Ralf
Index: lib/depcomp
===================================================================
RCS file: /cvs/automake/automake/lib/depcomp,v
retrieving revision 1.58
diff -u -r1.58 depcomp
--- lib/depcomp 9 Jul 2006 16:09:43 -0000 1.58
+++ lib/depcomp 29 Aug 2006 08:08:44 -0000
@@ -92,7 +92,7 @@
## gcc 3 implements dependency tracking that does exactly what
## we want. Yay! Note: for some reason libtool 1.4 doesn't like
## it if -MD -MP comes after the -MF stuff. Hmm.
- "$@" -MT "$object" -MD -MP -MF "$tmpdepfile"
+ "$@" -MT"$object" -MD -MP -MF"$tmpdepfile"
stat=$?
if test $stat -eq 0; then :
else