This is the mail archive of the
automake-prs@sources.redhat.com
mailing list for the automake project.
automake/326
- From: Alexandre Duret-Lutz <duret_g at lrde dot epita dot fr>
- To: tromey at redhat dot com
- Cc: automake-prs at sources dot redhat dot com,
- Date: 31 May 2002 14:41:00 -0000
- Subject: automake/326
- Reply-to: Alexandre Duret-Lutz <duret_g at lrde dot epita dot fr>
The following reply was made to PR automake/326; it has been noted by GNATS.
From: Alexandre Duret-Lutz <duret_g@lrde.epita.fr>
To: Richard Boulton <richard@tartarus.org>
Cc: automake-gnats@sources.redhat.com
Subject: automake/326
Date: Fri, 31 May 2002 16:40:54 +0200
>>> "Richard" == Richard Boulton <richard@tartarus.org> writes:
Richard> I attach mine here - I'll read through yours and then we can discuss
Richard> which we prefer.
Your solution is far better, definitely.
[...]
| + * test/cond21.test: New file
(cond21.test already exists in HEAD.)
[...]
| @@ -2332,7 +2337,15 @@
| # small C programs, all testing the same set of source files.
| sub subobjname (@)
| {
| - my $key = "@_";
| + my $key = '';
| + foreach my $pair (@_)
| + {
| + my ($cond, @result) = @$pair;
| + foreach my $item (@result)
| + {
| + $key .= join(':',$cond) . ' ' . $item;
| + }
| + }
I think `join(':',$cond)' is the same as `$cond' :)
Maybe this inner loop could be shortened to
$key .= "($cond)@result";
[...]
--
Alexandre Duret-Lutz