Critical
Things previously eliminated but returned. This should always be empty.
| BUG | Total | Description |
|---|---|---|
| ATTRIBUTE UNUSED | 17 | Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB |
| 1 | 17 |
Code
Coding standard problems, portability problems, readability problems.
| BUG | Total | Description |
|---|---|---|
| OP eol | 194 | Do not use &&, or || at the end of a line |
| sprintf | 152 | Do not use sprintf, instead use xstrprintf |
| if assignment | 88 | An IF statement's expression contains an assignment |
| long long | 54 | Do not use `long long', instead use LONGEST |
| inline | 25 | Do not use the inline attribute; since the compiler generally ignores this, better algorithm selection is needed to improved performance |
| editCase function | 20 | Function name starts lower case but has uppercased letters. |
| %ll | 19 | Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value |
| UCASE function | 17 | Function name is uppercase. |
| if clause more than 50 lines | 0 | An IF statement's expression expands over 50 lines |
| %p | 0 | Do not use printf("%p"), instead use printf("%s",paddr()) to dump a target address, or host_address_to_string() for a host address |
| 10 | 569 |
Comments
Problems concerning comments in source files.
| BUG | Total | Description |
|---|---|---|
| GNU/Linux | 38 | Do not use `Linux', instead use `Linux kernel' or `GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word `Linux' appears on the same line as the word `GNU' or `kernel' or a kernel version |
| 1 | 38 |
DOS 8.3 File Names
File names with problems on 8.3 file systems.
| BUG | Total | Description |
|---|---|---|
| DECIMAL1.H DOS 8.3 dup | 6 | DOSCHK - the names DECIMAL1.H and libdecnumber/bid/decimal128.h resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| DECIMAL3.H DOS 8.3 dup | 4 | DOSCHK - the names DECIMAL3.H and libdecnumber/bid/decimal32.h resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| DECIMAL6.H DOS 8.3 dup | 4 | DOSCHK - the names DECIMAL6.H and libdecnumber/bid/decimal64.h resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| DECNUMBE.H DOS 8.3 dup | 3 | DOSCHK - the names DECNUMBE.H and libdecnumber/decNumber.h resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| GNULIB-C.M4 DOS 8.3 dup | 3 | DOSCHK - the names GNULIB-C.M4 and gdb/gnulib/m4/gnulib-cache.m4 resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| HOST-IEE.C DOS 8.3 dup | 3 | DOSCHK - the names HOST-IEE.C and libdecnumber/bid/host-ieee128.c resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| WATCHPOI.C DOS 8.3 dup | 3 | DOSCHK - the names WATCHPOI.C and gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| WATCHPOI.EXP DOS 8.3 dup | 3 | DOSCHK - the names WATCHPOI.EXP and gdb/testsuite/gdb.base/watchpoint-hw-hit-once.exp resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| too many dots | 3 | DOSCHK - too many dots |
| CONSECUT.EXP DOS 8.3 dup | 2 | DOSCHK - the names CONSECUT.EXP and gdb/testsuite/gdb.reverse/consecutive-precsave.exp resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| DECCONTE.H DOS 8.3 dup | 2 | DOSCHK - the names DECCONTE.H and libdecnumber/decContext.h resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| DECDOUBL.H DOS 8.3 dup | 2 | DOSCHK - the names DECDOUBL.H and libdecnumber/decDouble.h resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| DECPACKE.H DOS 8.3 dup | 2 | DOSCHK - the names DECPACKE.H and libdecnumber/decPacked.h resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| DECSINGL.H DOS 8.3 dup | 2 | DOSCHK - the names DECSINGL.H and libdecnumber/decSingle.h resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| MACHINES.EXP DOS 8.3 dup | 2 | DOSCHK - the names MACHINES.EXP and gdb/testsuite/gdb.reverse/machinestate-precsave.exp resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| SEPDEBUG.C DOS 8.3 dup | 2 | DOSCHK - the names SEPDEBUG.C and gdb/testsuite/gdb.base/sepdebug.c resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| WATCHTHR.C DOS 8.3 dup | 2 | DOSCHK - the names WATCHTHR.C and gdb/testsuite/gdb.threads/watchthreads-reorder.c resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| WATCHTHR.EXP DOS 8.3 dup | 2 | DOSCHK - the names WATCHTHR.EXP and gdb/testsuite/gdb.threads/watchthreads-reorder.exp resolve to the same file on a DOS 8.3 system. For DOS, this can be fixed by modifying the file fnchange.lst. |
| 18 | 50 |
| BUG | Total | Description |
|---|---|---|
| deprecated sym private | 31 | Do not use deprecated sym_private, see declaration for details |
| deprecated child ops | 29 | Do not use deprecated child_ops, see declaration for details |
| deprecated xfer memory | 22 | Do not use deprecated xfer_memory, see declaration for details |
| deprecated sym stab info | 20 | Do not use deprecated sym_stab_info, see declaration for details |
| deprecated set value type | 18 | Do not use deprecated set_value_type, see declaration for details |
| deprecated ui loop hook | 10 | Do not use deprecated ui_loop_hook, see declaration for details |
| deprecated warn user | 10 | Do not use deprecated warn_user, see declaration for details |
| deprecated safe get selected frame | 9 | Do not use deprecated safe_get_selected_frame, see declaration for details |
| deprecated add core fns | 8 | Do not use deprecated add_core_fns, see declaration for details |
| deprecated detach hook | 8 | Do not use deprecated detach_hook, see declaration for details |
| deprecated command loop hook | 7 | Do not use deprecated command_loop_hook, see declaration for details |
| deprecated query hook | 7 | Do not use deprecated query_hook, see declaration for details |
| deprecated readline hook | 7 | Do not use deprecated readline_hook, see declaration for details |
| deprecated target wait hook | 7 | Do not use deprecated target_wait_hook, see declaration for details |
| deprecated exec file display hook | 6 | Do not use deprecated exec_file_display_hook, see declaration for details |
| deprecated fp regnum | 6 | Do not use deprecated fp_regnum, see declaration for details |
| deprecated readline begin hook | 6 | Do not use deprecated readline_begin_hook, see declaration for details |
| deprecated readline end hook | 6 | Do not use deprecated readline_end_hook, see declaration for details |
| deprecated remove raw breakpoint | 6 | Do not use deprecated remove_raw_breakpoint, see declaration for details |
| deprecated throw reason | 6 | Do not use deprecated throw_reason, see declaration for details |
| deprecated ui load progress hook | 6 | Do not use deprecated ui_load_progress_hook, see declaration for details |
| deprecated context hook | 5 | Do not use deprecated context_hook, see declaration for details |
| deprecated function start offset | 5 | Do not use deprecated function_start_offset, see declaration for details |
| deprecated init ui hook | 5 | Do not use deprecated init_ui_hook, see declaration for details |
| deprecated print frame info listing hook | 5 | Do not use deprecated print_frame_info_listing_hook, see declaration for details |
| deprecated register changed hook | 5 | Do not use deprecated register_changed_hook, see declaration for details |
| deprecated warning hook | 5 | Do not use deprecated warning_hook, see declaration for details |
| deprecated insert raw breakpoint | 4 | Do not use deprecated insert_raw_breakpoint, see declaration for details |
| deprecated selected frame level changed hook | 4 | Do not use deprecated selected_frame_level_changed_hook, see declaration for details |
| deprecated value modifiable | 4 | Do not use deprecated value_modifiable, see declaration for details |
| deprecated call command hook | 3 | Do not use deprecated call_command_hook, see declaration for details |
| deprecated cmd warning | 3 | Do not use deprecated cmd_warning, see declaration for details |
| deprecated error begin hook | 3 | Do not use deprecated error_begin_hook, see declaration for details |
| deprecated interactive hook | 3 | Do not use deprecated interactive_hook, see declaration for details |
| deprecated set gdbarch data | 3 | Do not use deprecated set_gdbarch_data, see declaration for details |
| deprecated show load progress | 3 | Do not use deprecated show_load_progress, see declaration for details |
| deprecated show value hack | 3 | Do not use deprecated show_value_hack, see declaration for details |
| deprecated trace start stop hook | 3 | Do not use deprecated trace_start_stop_hook, see declaration for details |
| deprecated annotate signal hook | 2 | Do not use deprecated annotate_signal_hook, see declaration for details |
| deprecated annotate signalled hook | 2 | Do not use deprecated annotate_signalled_hook, see declaration for details |
| deprecated attach hook | 2 | Do not use deprecated attach_hook, see declaration for details |
| deprecated file changed hook | 2 | Do not use deprecated file_changed_hook, see declaration for details |
| deprecated ibm6000 target | 2 | Do not use deprecated ibm6000_target, see declaration for details |
| deprecated post add symbol hook | 2 | Do not use deprecated post_add_symbol_hook, see declaration for details |
| deprecated pre add symbol hook | 2 | Do not use deprecated pre_add_symbol_hook, see declaration for details |
| deprecated set hook | 2 | Do not use deprecated set_hook, see declaration for details |
| deprecated target gdbarch select hack | 2 | Do not use deprecated target_gdbarch_select_hack, see declaration for details |
| deprecated core resize section table | 1 | Do not use deprecated core_resize_section_table, see declaration for details |
| deprecated pc in call dummy | 1 | Do not use deprecated pc_in_call_dummy, see declaration for details |
| deprecated trace find hook | 1 | Do not use deprecated trace_find_hook, see declaration for details |
| deprecated value frame id hack | 1 | Do not use deprecated value_frame_id_hack, see declaration for details |
| deprecated value internalvar hack | 1 | Do not use deprecated value_internalvar_hack, see declaration for details |
| deprecated value lval hack | 1 | Do not use deprecated value_lval_hack, see declaration for details |
| deprecated value regnum hack | 1 | Do not use deprecated value_regnum_hack, see declaration for details |
| deprecated debug xfer memory | 0 | Do not use deprecated debug_xfer_memory, see declaration for details |
| deprecated mips set processor regs hack | 0 | Do not use deprecated mips_set_processor_regs_hack, see declaration for details |
| deprecated serial fd | 0 | Do not use deprecated serial_fd, see declaration for details |
| deprecated set value modifiable | 0 | Do not use deprecated set_value_modifiable, see declaration for details |
| deprecated flush hook | -1 | Do not use deprecated flush_hook, see declaration for details |
| deprecated target resume hook | -1 | Do not use deprecated target_resume_hook, see declaration for details |
| deprecated target wait loop hook | -1 | Do not use deprecated target_wait_loop_hook, see declaration for details |
| 61 | 445 |
| BUG | Total | Description |
|---|---|---|
| frame register read | 19 | Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register() |
| get frame base | 16 | Replace get_frame_base with get_frame_id, get_frame_base_address, get_frame_locals_address, or get_frame_args_address. |
| 2 | 35 |
| BUG | Total | Description |
|---|---|---|
| write memory | 137 | Replace write_memory() with regcache_read() et.al. |
| read memory | 125 | Replace read_memory() with regcache_read() et.al. |
| write pc | 25 | Replace write_pc() with get_frame_base_address or get_frame_id; at present the inferior function call code still uses this when doing a DECR_PC_AFTER_BREAK |
| read pc | 13 | Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this |
| SOLIB ADD | 8 | Replace SOLIB_ADD with nothing, not needed? |
| SOLIB CREATE INFERIOR HOOK | 7 | Replace SOLIB_CREATE_INFERIOR_HOOK with nothing, not needed? |
| GCC2 COMPILED FLAG SYMBOL | 6 | Replace GCC2_COMPILED_FLAG_SYMBOL with nothing, not needed? |
| GCC COMPILED FLAG SYMBOL | 5 | Replace GCC_COMPILED_FLAG_SYMBOL with nothing, not needed? |
| PC SOLIB | 5 | Replace PC_SOLIB with nothing, not needed? |
| 9 | 331 |
| BUG | Total | Description |
|---|---|---|
| legacy register sim regno | 7 | Do not use legacy register_sim_regno, see declaration for details |
| legacy sim regno ignore | 3 | Do not use legacy sim_regno_ignore, see declaration for details |
| legacy name | 2 | Do not use legacy name, see declaration for details |
| legacy virtual frame pointer | 2 | Do not use legacy virtual_frame_pointer, see declaration for details |
| 4 | 22 |
| BUG | Total | Description |
|---|---|---|
| set register name | 61 | Call to set_gdbarch_register_name |
| set return value | 55 | Call to set_gdbarch_return_value |
| set num regs | 51 | Call to set_gdbarch_num_regs |
| set push dummy call | 48 | Call to set_gdbarch_push_dummy_call |
| set register type | 44 | Call to set_gdbarch_register_type |
| set long double bit | 40 | Call to set_gdbarch_long_double_bit |
| set print insn | 40 | Call to set_gdbarch_print_insn |
| set skip prologue | 37 | Call to set_gdbarch_skip_prologue |
| set sp regnum | 37 | Call to set_gdbarch_sp_regnum |
| set unwind pc | 37 | Call to set_gdbarch_unwind_pc |
| set ptr bit | 36 | Call to set_gdbarch_ptr_bit |
| set breakpoint from pc | 35 | Call to set_gdbarch_breakpoint_from_pc |
| set dummy id | 35 | Call to set_gdbarch_dummy_id |
| set pc regnum | 35 | Call to set_gdbarch_pc_regnum |
| set inner than | 34 | Call to set_gdbarch_inner_than |
| set num pseudo regs | 32 | Call to set_gdbarch_num_pseudo_regs |
| set regset from core section | 31 | Call to set_gdbarch_regset_from_core_section |
| set long bit | 30 | Call to set_gdbarch_long_bit |
| set skip trampoline code | 29 | Call to set_gdbarch_skip_trampoline_code |
| set long long bit | 26 | Call to set_gdbarch_long_long_bit |
| set frame align | 24 | Call to set_gdbarch_frame_align |
| set long double format | 24 | Call to set_gdbarch_long_double_format |
| set pseudo register read | 23 | Call to set_gdbarch_pseudo_register_read |
| set unwind sp | 23 | Call to set_gdbarch_unwind_sp |
| set double bit | 22 | Call to set_gdbarch_double_bit |
| set pseudo register write | 22 | Call to set_gdbarch_pseudo_register_write |
| set write pc | 22 | Call to set_gdbarch_write_pc |
| set dwarf2 reg to regnum | 21 | Call to set_gdbarch_dwarf2_reg_to_regnum |
| set fp0 regnum | 19 | Call to set_gdbarch_fp0_regnum |
| set int bit | 19 | Call to set_gdbarch_int_bit |
| set float bit | 17 | Call to set_gdbarch_float_bit |
| set register reggroup p | 17 | Call to set_gdbarch_register_reggroup_p |
| set short bit | 17 | Call to set_gdbarch_short_bit |
| set software single step | 16 | Call to set_gdbarch_software_single_step |
| set addr bit | 15 | Call to set_gdbarch_addr_bit |
| set fetch tls load module address | 15 | Call to set_gdbarch_fetch_tls_load_module_address |
| set decr pc after break | 14 | Call to set_gdbarch_decr_pc_after_break |
| set skip solib resolver | 14 | Call to set_gdbarch_skip_solib_resolver |
| set stab reg to regnum | 14 | Call to set_gdbarch_stab_reg_to_regnum |
| set register sim regno | 13 | Call to set_gdbarch_register_sim_regno |
| set frame args skip | 12 | Call to set_gdbarch_frame_args_skip |
| set char signed | 11 | Call to set_gdbarch_char_signed |
| set believe pcc promotion | 10 | Call to set_gdbarch_believe_pcc_promotion |
| set get longjmp target | 10 | Call to set_gdbarch_get_longjmp_target |
| set read pc | 10 | Call to set_gdbarch_read_pc |
| set double format | 9 | Call to set_gdbarch_double_format |
| set in function epilogue p | 9 | Call to set_gdbarch_in_function_epilogue_p |
| set call dummy location | 8 | Call to set_gdbarch_call_dummy_location |
| set push dummy code | 8 | Call to set_gdbarch_push_dummy_code |
| set cannot store register | 7 | Call to set_gdbarch_cannot_store_register |
| set convert register p | 7 | Call to set_gdbarch_convert_register_p |
| set displaced step location | 7 | Call to set_gdbarch_displaced_step_location |
| set float format | 7 | Call to set_gdbarch_float_format |
| set have nonsteppable watchpoint | 7 | Call to set_gdbarch_have_nonsteppable_watchpoint |
| set register to value | 7 | Call to set_gdbarch_register_to_value |
| set value to register | 7 | Call to set_gdbarch_value_to_register |
| set address to pointer | 6 | Call to set_gdbarch_address_to_pointer |
| set cannot fetch register | 6 | Call to set_gdbarch_cannot_fetch_register |
| set displaced step copy insn | 6 | Call to set_gdbarch_displaced_step_copy_insn |
| set displaced step fixup | 6 | Call to set_gdbarch_displaced_step_fixup |
| set displaced step free closure | 6 | Call to set_gdbarch_displaced_step_free_closure |
| set pointer to address | 6 | Call to set_gdbarch_pointer_to_address |
| set ps regnum | 6 | Call to set_gdbarch_ps_regnum |
| set addr bits remove | 5 | Call to set_gdbarch_addr_bits_remove |
| set convert from func ptr addr | 5 | Call to set_gdbarch_convert_from_func_ptr_addr |
| set ecoff reg to regnum | 5 | Call to set_gdbarch_ecoff_reg_to_regnum |
| set frame red zone size | 5 | Call to set_gdbarch_frame_red_zone_size |
| set print registers info | 5 | Call to set_gdbarch_print_registers_info |
| set sofun address maybe missing | 5 | Call to set_gdbarch_sofun_address_maybe_missing |
| set core pid to str | 4 | Call to set_gdbarch_core_pid_to_str |
| set core reg section encodes pid | 4 | Call to set_gdbarch_core_reg_section_encodes_pid |
| set core regset sections | 4 | Call to set_gdbarch_core_regset_sections |
| set elf make msymbol special | 4 | Call to set_gdbarch_elf_make_msymbol_special |
| set gcore bfd target | 4 | Call to set_gdbarch_gcore_bfd_target |
| set max insn length | 4 | Call to set_gdbarch_max_insn_length |
| set memory remove breakpoint | 4 | Call to set_gdbarch_memory_remove_breakpoint |
| set skip main prologue | 4 | Call to set_gdbarch_skip_main_prologue |
| set vbit in delta | 4 | Call to set_gdbarch_vbit_in_delta |
| set deprecated fp regnum | 3 | Call to set_gdbarch_deprecated_fp_regnum |
| set fetch pointer argument | 3 | Call to set_gdbarch_fetch_pointer_argument |
| set from file | 3 | Call to set_gdbarch_from_file |
| set get siginfo type | 3 | Call to set_gdbarch_get_siginfo_type |
| set get syscall number | 3 | Call to set_gdbarch_get_syscall_number |
| set integer to address | 3 | Call to set_gdbarch_integer_to_address |
| set overlay update | 3 | Call to set_gdbarch_overlay_update |
| set print float info | 3 | Call to set_gdbarch_print_float_info |
| set process record | 3 | Call to set_gdbarch_process_record |
| set stabs argument has addr | 3 | Call to set_gdbarch_stabs_argument_has_addr |
| set static transform name | 3 | Call to set_gdbarch_static_transform_name |
| set virtual frame pointer | 3 | Call to set_gdbarch_virtual_frame_pointer |
| set address class name to type flags | 2 | Call to set_gdbarch_address_class_name_to_type_flags |
| set address class type flags | 2 | Call to set_gdbarch_address_class_type_flags |
| set address class type flags to name | 2 | Call to set_gdbarch_address_class_type_flags_to_name |
| set adjust breakpoint address | 2 | Call to set_gdbarch_adjust_breakpoint_address |
| set cannot step breakpoint | 2 | Call to set_gdbarch_cannot_step_breakpoint |
| set core read description | 2 | Call to set_gdbarch_core_read_description |
| set in solib return trampoline | 2 | Call to set_gdbarch_in_solib_return_trampoline |
| set memory insert breakpoint | 2 | Call to set_gdbarch_memory_insert_breakpoint |
| set process record signal | 2 | Call to set_gdbarch_process_record_signal |
| set sdb reg to regnum | 2 | Call to set_gdbarch_sdb_reg_to_regnum |
| set single step through delay | 2 | Call to set_gdbarch_single_step_through_delay |
| set skip permanent breakpoint | 2 | Call to set_gdbarch_skip_permanent_breakpoint |
| set smash text address | 2 | Call to set_gdbarch_smash_text_address |
| set value from register | 2 | Call to set_gdbarch_value_from_register |
| set coff make msymbol special | 1 | Call to set_gdbarch_coff_make_msymbol_special |
| set core xfer shared libraries | 1 | Call to set_gdbarch_core_xfer_shared_libraries |
| set deprecated function start offset | 1 | Call to set_gdbarch_deprecated_function_start_offset |
| set displaced step hw singlestep | 1 | Call to set_gdbarch_displaced_step_hw_singlestep |
| set frame num args | 1 | Call to set_gdbarch_frame_num_args |
| set has global breakpoints | 1 | Call to set_gdbarch_has_global_breakpoints |
| set has global solist | 1 | Call to set_gdbarch_has_global_solist |
| set record special symbol | 1 | Call to set_gdbarch_record_special_symbol |
| set remote register number | 1 | Call to set_gdbarch_remote_register_number |
| set vtable function descriptors | 1 | Call to set_gdbarch_vtable_function_descriptors |
| set bits big endian | 0 | Call to set_gdbarch_bits_big_endian |
| set has shared address space | 0 | Call to set_gdbarch_has_shared_address_space |
| set print vector info | 0 | Call to set_gdbarch_print_vector_info |
| set target signal from host | 0 | Call to set_gdbarch_target_signal_from_host |
| set target signal to host | 0 | Call to set_gdbarch_target_signal_to_host |
| 119 | 1700 |
Macro
Breakdown of macro definitions (and #undef) in configuration files.
| BUG | Total | Description |
|---|---|---|
| nm GDB FPREGSET T | 2 | Do not define macros such as GDB_FPREGSET_T in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm GDB GREGSET T | 2 | Do not define macros such as GDB_GREGSET_T in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| macro CODESET | 1 | Do not define macros such as CODESET in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm CANNOT STEP HW WATCHPOINTS | 1 | Do not define macros such as CANNOT_STEP_HW_WATCHPOINTS in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm DEPRECATED IBM6000 TARGET | 1 | Do not define macros such as DEPRECATED_IBM6000_TARGET in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm FILL FPXREGSET | 1 | Do not define macros such as FILL_FPXREGSET in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm GET THREAD SIGNALS | 1 | Do not define macros such as GET_THREAD_SIGNALS in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm PC SOLIB | 1 | Do not define macros such as PC_SOLIB in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm PROCFS DONT TRACE FAULTS | 1 | Do not define macros such as PROCFS_DONT_TRACE_FAULTS in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm PROCFS NEED CLEAR CURSIG FOR KILL | 1 | Do not define macros such as PROCFS_NEED_CLEAR_CURSIG_FOR_KILL in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm REALTIME HI | 1 | Do not define macros such as REALTIME_HI in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm REALTIME LO | 1 | Do not define macros such as REALTIME_LO in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm SOLIB ADD | 1 | Do not define macros such as SOLIB_ADD in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm SOLIB CREATE INFERIOR HOOK | 1 | Do not define macros such as SOLIB_CREATE_INFERIOR_HOOK in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm START INFERIOR TRAPS EXPECTED | 1 | Do not define macros such as START_INFERIOR_TRAPS_EXPECTED in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm THREAD STATE CLEAR TRACED | 1 | Do not define macros such as THREAD_STATE_CLEAR_TRACED in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm THREAD STATE FLAVOR | 1 | Do not define macros such as THREAD_STATE_FLAVOR in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm THREAD STATE SET TRACED | 1 | Do not define macros such as THREAD_STATE_SET_TRACED in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| nm THREAD STATE SIZE | 1 | Do not define macros such as THREAD_STATE_SIZE in a tm, nm or xm file, in fact do not provide a tm, nm or xm file |
| 19 | 21 |
Fixed
Problems that have been expunged from the source code.
| BUG | Total | Description |
|---|---|---|
| ATTRIBUTE UNUSED | 17 | Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings. Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB |
| ADD SHARED SYMBOL FILES | 0 | Replace ADD_SHARED_SYMBOL_FILES with nothing, not needed? |
| ARGSUSED | 0 | Do not use ARGSUSED, unnecessary |
| BIG ENDIAN | 0 | Do not use BIG_ENDIAN, instead use BFD_ENDIAN_BIG |
| CYGWIN32 | 0 | Do not use __CYGWIN32__, instead use __CYGWIN__ or, better, an explicit autoconf tests |
| FUNCTION | 0 | Do not use __FUNCTION__, ISO C 90 does not support this macro |
| FUNCTION EPILOGUE SIZE | 0 | Replace FUNCTION_EPILOGUE_SIZE with nothing, not needed? |
| HAVE VFORK | 0 | Do not use HAVE_VFORK, instead include "gdb_vfork.h" and call vfork() unconditionally |
| IN SOLIB DYNSYM RESOLVE CODE | 0 | Replace IN_SOLIB_DYNSYM_RESOLVE_CODE with nothing, not needed? |
| LITTLE ENDIAN | 0 | Do not use LITTLE_ENDIAN, instead use BFD_ENDIAN_LITTLE |
| PARAMS | 0 | Do not use PARAMS(), ISO C 90 implies prototypes |
| PROCESS LINENUMBER HOOK | 0 | Replace PROCESS_LINENUMBER_HOOK with nothing, not needed? |
| PTR | 0 | Do not use PTR, ISO C 90 implies `void *' |
| REGISTER U ADDR | 0 | Replace REGISTER_U_ADDR with nothing, not needed? |
| SOLIB LOADED LIBRARY PATHNAME | 0 | Replace SOLIB_LOADED_LIBRARY_PATHNAME with nothing, not needed? |
| TARGET HAS HARDWARE WATCHPOINTS | 0 | Replace TARGET_HAS_HARDWARE_WATCHPOINTS with nothing, not needed |
| abort | 0 | Do not use abort, instead use internal_error; GDB should never abort |
| asprintf | 0 | Do not use asprintf(), instead use xstrprintf() |
| assert | 0 | Do not use assert, instead use gdb_assert or internal_error; assert calls abort and GDB should never call abort |
| assert.h | 0 | Do not include assert.h, instead include "gdb_assert.h" |
| basename | 0 | Do not use basename, instead use lbasename |
| bcmp | 0 | Do not use bcmp(), ISO C 90 implies memcmp() |
| bcopy | 0 | Do not use bcopy(), ISO C 90 implies memcpy() and memmove() |
| boolean | 0 | Do not use `boolean', use `int' instead |
| bzero | 0 | Do not use bzero(), instead use memset() |
| dirent.h | 0 | Do not include dirent.h, instead include gdb_dirent.h |
| d namelen | 0 | Do not use dirent.d_namelen, instead use NAMELEN |
| error not internal-warning | 0 | Do not use error("internal-warning"), instead use internal_warning |
| false | 0 | Definitely do not use `false' in boolean expressions |
| floatformat from double | 0 | Do not use floatformat_from_double() from libierty, instead use floatformat_from_doublest() |
| floatformat to double | 0 | Do not use floatformat_to_double() from libierty, instead use floatformat_to_doublest() |
| frame unwind unsigned register | 0 | Replace frame_unwind_unsigned_register with frame_unwind_register_unsigned |
| func | 0 | Do not use __func__, ISO C 90 does not support this macro |
| generic target write pc | 0 | Replace generic_target_write_pc with a per-architecture implementation, this relies on PC_REGNUM which is being eliminated |
| generic use struct convention | 0 | Replace generic_use_struct_convention with nothing, EXTRACT_STRUCT_VALUE_ADDRESS is a predicate |
| gnu-regex.h | 0 | Do not include gnu-regex.h, instead include gdb_regex.h |
| hash | 0 | Do not use ` #...', instead use `#...'(some compilers only correctly parse a C preprocessor directive when `#' is the first character on the line) |
| multi-line string | 0 | Multi-line string must have the newline escaped |
| read register | 0 | Replace read_register() with regcache_read() et.al. |
| read sp | 0 | Replace read_sp() with frame_sp_unwind |
| regex.h | 0 | Do not include regex.h, instead include gdb_regex.h |
| register cached | 0 | Replace register_cached() with nothing, does not have a regcache parameter |
| sec ptr | 0 | Instead of sec_ptr, use struct bfd_section |
| setlinebuf | 0 | Do not use setlinebuf(), ISO C 90 implies setvbuf() |
| set register cached | 0 | Replace set_register_cached() with nothing, does not have a regcache parameter |
| stat.h | 0 | Do not include stat.h or sys/stat.h, instead include gdb_stat.h |
| strdup | 0 | Do not use strdup(), instead use xstrdup() |
| strerror | 0 | Do not use strerror(), instead use safe_strerror() |
| strlen d name | 0 | Do not use strlen dirent.d_name, instead use NAMELEN |
| strnicmp | 0 | Do not use strnicmp(), instead use strncasecmp() |
| strsave | 0 | Do not use strsave(), instead use xstrdup() et.al. |
| true | 0 | Do not try to use `true' in boolean expressions |
| var boolean | 0 | Replace var_boolean with add_setshow_boolean_cmd |
| vasprintf | 0 | Do not use vasprintf(), instead use xstrvprintf |
| vfork.h | 0 | Do not include vfork.h, instead include gdb_vfork.h |
| vsprint | 0 | Do not use vsprint(), instead use xstrvprintf |
| wait.h | 0 | Do not include wait.h or sys/wait.h, instead include gdb_wait.h |
| write register | 0 | Replace write_register() with regcache_read() et.al. |
| xasprintf | 0 | Do not use xasprintf(), instead use xstrprintf |
| xregex.h | 0 | Do not include xregex.h, instead include gdb_regex.h |
| xvasprintf | 0 | Do not use xvasprintf(), instead use xstrvprintf |
| 61 | 17 |
Please send FSF & GNU inquiries & questions to gnu@gnu.org. There are also other ways to contact the FSF.
This page is maintained by the GDB developers.
Copyright Free Software Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
Last modified 2009-12-08.